Make NodeManager optional #1142
Open
+940
−439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
optional-node-manager
branch
from
db1704a
to
f3aece1
Compare
benthecarman
force-pushed
the
optional-node-manager
branch
2 times, most recently
from
23692b2
to
ae0eafa
Compare
|
This is getting close, want to write tests for everything but in my manual testing things seem to be working well |
TonyGiorgio
reviewed
Apr 17, 2024
|
|
benthecarman
force-pushed
the
optional-node-manager
branch
3 times, most recently
from
4d6002d
to
4b9d5cb
Compare
benthecarman
force-pushed
the
optional-node-manager
branch
from
4b9d5cb
to
2f77928
Compare
benthecarman
force-pushed
the
optional-node-manager
branch
from
2f77928
to
f04512e
Compare
|
needs rebase |
benthecarman
force-pushed
the
optional-node-manager
branch
from
f04512e
to
00c38ee
Compare
|
Errors when receiving on chain when only a federation is added 
|
TonyGiorgio
requested changes
Jun 7, 2024
benthecarman
force-pushed
the
optional-node-manager
branch
from
00c38ee
to
34165c5
Compare
|
Went through full testing guide, everything is working as of now. Going to add a few more things to it that will now apply with this |
|
discussed in meeting: don't default remove empty node managers |
benthecarman
force-pushed
the
optional-node-manager
branch
from
44bb3fd
to
b8551de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to fix #1071 while i was at it
This puts the node manager in a RwLock that is by default off, only until
create_node_manageris called will we have a lightning node and on-chain wallet. Otherwise it will use fedimint when there is no nodemanager or throw an error if neither are configured.